GH-112675: Move path joining tests into test_posixpath and test_ntpath#112676
Merged
barneygale merged 1 commit intopython:mainfrom Dec 7, 2023
Merged
GH-112675: Move path joining tests into test_posixpath and test_ntpath#112676barneygale merged 1 commit intopython:mainfrom
test_posixpath and test_ntpath#112676barneygale merged 1 commit intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
test_pathlib, thecheck_drive_root_partstest methods evaluated both joining and parsing/normalisation of paths. This dates from a time when pathlib implemented both functions itself, but nowadays path joining is done withposixpath.join()andntpath.join().This PR moves the joining-related test cases into
test_posixpathandtest_ntpath.test_pathlibare misplaced #112675